-
Notifications
You must be signed in to change notification settings - Fork 30
Fixed a little computational error as it is my first open source contribution #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OmarAlmighty
merged 1 commit into
OmarAlmighty:master
from
Ahtisham-1214:Fix_Computational_Issue
Aug 26, 2024
Merged
Fixed a little computational error as it is my first open source contribution #2
OmarAlmighty
merged 1 commit into
OmarAlmighty:master
from
Ahtisham-1214:Fix_Computational_Issue
Aug 26, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for considering my error highlight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the problem is given in the book was about sum of fractional series the series is increasing by 2, but you were not incrementing the loop by 2. Hence it was giving a logical error. When I was solving the problems of book I find hurdle so I get your repo where whenever I do a book problem I compare the my solution with you and I find that mistake so I think to solve it because I just learn Git & GitHub, Indeed doing open source contribution taught me how to use Git & GitHub but you're a legend.
Actual_Probelm