Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FreeBSD code updates in order to get core module compiling under it#660

Open
Teetoow wants to merge 13 commits into
ONLYOFFICE:master from
Teetoow:master
Open

FreeBSD code updates in order to get core module compiling under it #660
Teetoow wants to merge 13 commits into
ONLYOFFICE:master from
Teetoow:master

Conversation

@Teetoow

@Teetoow Teetoow commented Jul 19, 2021

Copy link
Copy Markdown

I updated my patch with the latest version of this module in order to get DocumentServer compiling and working under FreeBSD.
Please note that this pull request contains different patches :

  • most of them are preproc conditions (or qmake conditions) specific to FreeBSD: they won't impact other operating systems so they are really safe and can be integrated into your code without any trouble
  • several bugs have been corrected (FreeBSD compiler is really strict). Most of them are casting problem (wrong use of NULL)
  • one bug correction is related to the use of a V8 protected function. The public one needs the use of "isolate". Please check it.

Teetoow added 13 commits August 24, 2020 16:34
use the officially V8 sources build with the DocumentServer scrit. A
workaround is to use FreeBSD ports to get V8
2. Add a specific FreeBSD routine in order to get the correct path of
 binary which corresponds to the current running process
...ch cannot be
executed in this scope. "isolate" argument might correct the bug
guess that you wanted to reset the pointer so using "*" is wrong. If you
want to reset the data buffer content you might first check that pData
is not equal to NULL and then do: "*pData = (char)0;". NULL is
equivalent to a pointer (its cast is void*) not a byte nor a char.

CLAassistant commented Jul 19, 2021
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /