-
Notifications
You must be signed in to change notification settings - Fork 0
Comments
Open
Conversation
We’re currently at 60% test coverage, so this forces us to write more tests whenever anything new is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We’re currently at 60% test coverage, so this forces us to write more tests whenever anything new is added.
Also:
I created a pull request for this because I’d like to capture a pull request merge event for tests, so we can use it like this push event.
Myself or @joshfinnie will need to capture the console output of the Heroku logs at the time this is merged so we can store it — the only caveat is that I can’t merge this (since I’d like to add a test assertion which will catch #2).