-
Notifications
You must be signed in to change notification settings - Fork 0
docs(trustguard): remove the WAF collectors - #220
Merged
Merged
Conversation
WAF support is being dropped, so the four edge collectors go with it: Cloudflare, AWS CloudFront, Fastly Compute and Akamai EdgeWorkers. Deletes the four guides, the WAF navigation group, the WAF row from the catalog table and from the Collectors group table, and the Edge and WAF section of the integrations index. The catalog is now sixteen collector types in three groups. The redirects from those paths to the integrations index already exist from the earlier navigation reorganization and are kept, so old links still land somewhere useful. Cloudflare references in the SSO, generic-OIDC and deployment-troubleshooting pages are untouched: those are DNS-provider examples and the Turnstile endpoint, unrelated to collectors.
Trivy code scan — HIGH/CRITICAL
No HIGH or CRITICAL vulnerabilities found. (run)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAF support is being dropped (RUN-1283), so the four edge collector guides go with it.
Platform side: NeuralTrust/app#3506.
What changed
integrations/{cloudflare,aws-cloudfront,fastly,akamai}.mdxdocs.jsontrustguard/overview.mdxand from the group table inconcepts/collectors.mdx— the catalog is now sixteen collector types in three groupsRedirects kept
/integrations/cloudflare,/trustguard/integrations/cloudflare,/trustguard/integrations/edge-waf/cloudflareand the equivalents for the other three already redirect to/integrations/overviewfrom the earlier navigation reorganization. They are kept, so old links still land somewhere useful.Those redirects also explain something about #218: it restored these four pages while redirects for the same sources were still in
docs.json, so the restored pages were most likely shadowed and never actually served. Moot now, but worth knowing — a restored page needs its redirect removed to be reachable.Not touched
Cloudflare appears in three other pages for unrelated reasons and stays as is: DNS-provider examples in
platform/sso.mdxandplatform/generic-oidc-sso.mdx, and thechallenges.cloudflare.comTurnstile endpoint inneuraltrust/deployment/troubleshooting.mdx.Verification
python3 scripts/check-navigation.pypasses with 165 entries. No remaining links to the four deleted pages anywhere in the repo except the intentional redirects.Sequencing
The app PR withdraws WAF from the catalog but keeps the ids resolvable, so existing WAF collectors keep rendering. These two should land in the same release: docs first would leave four offered-but-undocumented collectors, app first would leave four documented-but-absent ones — the exact drift this epic has been fixing.