Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

upgrade to nodejs 16 and packaging 24.1#9384

Open
artydeez wants to merge 3 commits intoNetflix:master from
artydeez:fix/npm_build_issue
Open

upgrade to nodejs 16 and packaging 24.1 #9384
artydeez wants to merge 3 commits intoNetflix:master from
artydeez:fix/npm_build_issue

Conversation

@artydeez
Copy link

@artydeez artydeez commented Sep 10, 2024

  • Due to nodejs 14 deprecation, npm binary was no longer installed successfully during build process. Upgrading to nodejs 16 fixes this
  • Started to see build failures for setuptools after upgrading to nodejs 16 but don't believe they are related
#16 1.303 File "/usr/local/lib/python3.10/site-packages/setuptools/_core_metadata.py", line 285, in _distribution_fullname
#16 1.303 canonicalize_version(version, strip_trailing_zero=False),
#16 1.303 TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'

this is fixed up updating the packing pip to 24.1

Copy link

ghost commented Feb 28, 2025

@scottpacknetflix @jaydhulia can this be merged? was curious to use the docker image.

Copy link

ghost commented Feb 28, 2025

Also cc @patricksanders. I think the latest dockerhub image does not contain a fix for the last CVE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /