This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
refactor: HMR and webpack improvements #966
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchimev
vchimev
reviewed
Jul 5, 2019
vchimev
vchimev
reviewed
Jul 5, 2019
vchimev
vchimev
approved these changes
Jul 5, 2019
DimitarTachev
DimitarTachev
approved these changes
Jul 5, 2019
@vakrilov
vakrilov
force-pushed
the
file-qualifiers
branch
from
July 5, 2019 13:56
21787f2 to
f223fcf
Compare
test package_version#rc
@vakrilov
vakrilov
force-pushed
the
file-qualifiers
branch
from
July 8, 2019 08:15
04df474 to
9e093f0
Compare
@cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
This was referenced Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
In this PR:
.xml/.js/ts/.cssfiles to the bundle (except files in theApp_Resources). Previously it was only files with-pagesuffix.hmr/hot-loaderwhich is used for JS and TS templates. It will process all.xml/.js/ts/.cssfiles and it will add code that will enable HMR self-accept (module.hot.accept()) if the module was loaded fromtns-core-module/ui/builderusing theglobal._isModuleLoadedForUI()API from this PR: refactor: HMR and webpack improvements NativeScript#7462hmr/folder converted to TypeScriptWarning: This PR should be merged together with his brother -> NativeScript/NativeScript#7462
Known Issue
If you have custom android application or activity it is pulled in the
bundle.jsby therequire.context. You can exclude it by writing magical regex (like this), but there might be an easier way to do it.Related to #902