Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat(snapshot): The parameters passed to mksnapshot are now retrieved... #789

Merged
darind merged 2 commits into master from darind/v8-7.2.502.24
Feb 6, 2019

Conversation

Copy link
Contributor

@darind darind commented Feb 6, 2019

PR Checklist

Related to NativeScript/android#1263

What is the current behavior?

The parameters passed to the mksnapshot tool are hardcoded in the webpack plugin (for example the --profile_deserialization flag).

What is the new behavior?

The parameters passed to the mksnapshot tool are retrieved from the settings.json file of the installed android runtime. A fallback mechanism is provided for older android runtimes which do not have those parameters.

Why is this change required?

Recent V8 versions (notably >= 7.0) have become very strict on the parameters passed to mksnapshot. They must exactly match the parameters used to create V8's internal snapshot during the compilation process. Otherwise the layout of the snapshot binary might become invalid and result into segmentation faults. Because those parameters are very strictly related to the V8 version it makes more sense to store them as part of the runtime as they might change often.

For reference, here's a related issue in which we have discussed with Google engineers, various crashes related to those parameters: https://bugs.chromium.org/p/v8/issues/detail?id=8576. For example the --turbo_instruction_scheduling flag must now be specified.

vchimev reacted with thumbs up emoji
@darind darind merged commit cb68dac into master Feb 6, 2019
@darind darind deleted the darind/v8-7.2.502.24 branch February 6, 2019 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vtrifonov vtrifonov Awaiting requested review from vtrifonov

2 more reviewers

@manoldonev manoldonev manoldonev approved these changes

@vakrilov vakrilov vakrilov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /