This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat: NativeScript bootstrap transformer #634

Merged

sis0k0 merged 4 commits into master from replace-bootstrap

Aug 17, 2018

Merged

feat: NativeScript bootstrap transformer #634

sis0k0 merged 4 commits into master from replace-bootstrap

Aug 17, 2018

Conversation

vakrilov

Copy link

Contributor

@vakrilov vakrilov commented Aug 15, 2018 •

edited

Loading

The bootstrap transformer will automatically replace the platform and bootstrap calls inside main.ts when building with AOT.
This will eliminate the need for main.aot.ts and app.module.ngfactory.d.ts files in templates.

This depends on angular/angular-cli#11786 going public

sis0k0

sis0k0 suggested changes

Aug 15, 2018

View reviewed changes

templates/webpack.angular.js Outdated

const webpack = require("webpack");

const nsWebpack = require("nativescript-dev-webpack");

const nativescriptTarget = require("nativescript-dev-webpack/nativescript-target");

const { nsReplaceBootstrap } = require("nativescript-dev-webpack/plugins/ns-replace-bootstrap");

Copy link

Contributor

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reexport that from the index file?

templates/webpack.angular.js

const entryModule = aot ?

nsWebpack.getAotEntryModule(appFullPath) :

`${nsWebpack.getEntryModule(appFullPath)}.ts`;

const entryModule = `${nsWebpack.getEntryModule(appFullPath)}.ts`;

Copy link

Contributor

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the getAotEntryModule function from index.js as well.

Copy link

Contributor Author

@vakrilov vakrilov Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breaking change if we remove it completely.

Copy link

Contributor

@sis0k0 sis0k0 Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. We discussed to introduce a Deprecated decorator in another PR.

templates/webpack.angular.js Outdated

const ngCompilerPlugin = new AngularCompilerPlugin({

hostReplacementPaths: nsWebpack.getResolver([platform, "tns"]),

platformTransformers: aot ? [nsReplaceBootstrap(() => ngCompilerPlugin)] : null,

mainPath: resolve(appPath, "main.ts"),

Copy link

Contributor

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, that's from a previous PR (mine ;d), but I think it should be mainPath: entryModule instead of hardcoded to main.ts.

tsconfig.json Outdated

"files": [

"plugins/PlatformFSPlugin.ts",

"plugins/WatchStateLoggerPlugin.ts",

"plugins/ns-replace-bootstrap.ts",

Copy link

Contributor

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm, that's not really a webpack plugin. Can we move it to a transformers folder or something like that.

@vakrilov vakrilov changed the title ~~(削除) [Do not merge] feat: NativeScript bootstrap transformer (削除ここまで)~~ (追記) feat: NativeScript bootstrap transformer (追記ここまで)

Aug 17, 2018

vakrilov and others added 4 commits

August 17, 2018 14:22

@sis0k0


 feat: NativeScript bootstrap transformer

e20dc2c

The bootstrap transformer will automatically replace the platform and bootstrap calls inside `main.ts` when building with AOT.
This will eliminate the need for `main.aot.ts` and `app.module.ngfactory.d.ts` files in templates.

@sis0k0


 refactor: bootstrap transformer moved to transformers

ff5eb37

@sis0k0


 chore: switched to ngtools/webpack@6.2.0-beta.3

0aa326a

@sis0k0


 refactor: stop reexporting transformer from index.js

c3a3b0b

This won't work for projects that don't have dependency for
`@ngtools/webpack`.

@sis0k0 sis0k0 force-pushed the replace-bootstrap branch from e65d008 to c3a3b0b Compare

August 17, 2018 11:26

sis0k0

sis0k0 approved these changes

Aug 17, 2018

View reviewed changes

@sis0k0 sis0k0 mentioned this pull request

Aug 17, 2018

Reflect the changes from nativescript-dev-webpack v0.16.0 NativeScript/nativescript-schematics#77

Closed

@sis0k0 sis0k0 merged commit c016418 into master

Aug 17, 2018

@sis0k0 sis0k0 deleted the replace-bootstrap branch

August 17, 2018 14:01

@sis0k0 sis0k0 mentioned this pull request

Aug 20, 2018

chore: remove AoT helper files telerik/template-find-a-doctor-ng#40

Closed

@sis0k0 sis0k0 mentioned this pull request

Aug 28, 2018

fix-next: add global process variable #642

Merged

sis0k0 added a commit that referenced this pull request

Aug 28, 2018

@sis0k0


 fix-next: add global process variable

188282b

It was removed (probably accidentally) in #634.

sis0k0 added a commit that referenced this pull request

Aug 31, 2018

@sis0k0


 fix-next: add global process variable ( #642 )

37dd661

It was removed (probably accidentally) in #634.

@sis0k0 sis0k0 mentioned this pull request

Sep 10, 2018

release: cut the 0.16.0 🎉 #648

Merged

sis0k0 added a commit that referenced this pull request

Sep 10, 2018

@sis0k0


 release: cut the 0.16.0 🎉 ( #648 )

de7d071

<a name="0.16.0"></a>
# [0.16.0](0.15.1...0.16.0) (2018年09月10日)
 ### Features
 * NativeScript bootstrap transformer ([#634](#634)) ([c016418](c016418))

manoldonev pushed a commit to NativeScript/nativescript-app-templates that referenced this pull request

Jan 9, 2019

@sis0k0 @manoldonev


 chore: remove AoT helper files ( #87 )

64f7a01

They won't be needed with {N}-dev-webpack 0.16.0, because of this change
- NativeScript/nativescript-dev-webpack#634.

Labels

None yet

2 participants

@vakrilov @sis0k0

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: NativeScript bootstrap transformer #634

feat: NativeScript bootstrap transformer #634

Uh oh!

Conversation

@vakrilov vakrilov commented Aug 15, 2018 •

edited

Loading

Uh oh!

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

@vakrilov vakrilov Aug 17, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 17, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: NativeScript bootstrap transformer #634

feat: NativeScript bootstrap transformer #634

Uh oh!

Conversation

@vakrilov vakrilov commented Aug 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

@vakrilov vakrilov Aug 17, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 17, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@vakrilov vakrilov commented Aug 15, 2018 •

edited

Loading