This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat(xml-namespace-loader): add ignore option #605

Merged

sis0k0 merged 4 commits into NativeScript:master from PeterStaev:issue-558

Jul 23, 2018

Merged

feat(xml-namespace-loader): add ignore option #605

sis0k0 merged 4 commits into NativeScript:master from PeterStaev:issue-558

Jul 23, 2018

Conversation

PeterStaev

Copy link

Contributor

@PeterStaev PeterStaev commented Jul 6, 2018

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

What is the current behavior?

There is no way to exclude local modules. This causes problems with typescript based apps.

What is the new behavior?

With the ignore option user can exclude any local fragments and register them either manually or by using the registerModules regex option for the bundle-config-loader

Closes #558.

@PeterStaev


 feat(xml-namespace-loader): add ignore option

d5d4732

@sis0k0

Copy link

Contributor

sis0k0 commented Jul 16, 2018

I think this might be unnecessary, because you can remove the loader from the webpack config. Am I missing something?

@PeterStaev

Copy link

Contributor Author

PeterStaev commented Jul 16, 2018

If you remove the loader, then you also have to manually register plugins included in the XML files. What I would like is still leave the automatic registration of plugins (which works pretty awesome) and only ignore the local fragments which have issues with the automatic registration.