This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

Merged

vchimev merged 20 commits into master from vchimev/component-resolve-windows

Jun 26, 2018

Merged

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

vchimev merged 20 commits into master from vchimev/component-resolve-windows

Jun 26, 2018

Conversation

vchimev

Copy link

Contributor

@vchimev vchimev commented Jun 21, 2018

Fixes #573.

@vchimev vchimev force-pushed the vchimev/component-resolve-windows branch from 78305d6 to adb67b4 Compare

June 21, 2018 21:59

@vchimev vchimev requested a review from sis0k0

June 21, 2018 22:00

@vchimev vchimev self-assigned this

Jun 21, 2018

@vchimev vchimev requested a review from manoldonev

June 22, 2018 05:52

@vchimev vchimev force-pushed the vchimev/component-resolve-windows branch 2 times, most recently from 2d06055 to ba89c28 Compare

June 22, 2018 13:39

sis0k0

sis0k0 suggested changes

Jun 22, 2018

View reviewed changes

android-app-components-loader.js Outdated

this.cacheable();

const { modules } = this.query;

const imports = modules.map(m => `require("${m}");`).join("\n");

const imports = modules.map(m => convertSlashesInPath(m))

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.map(m => convertSlashesInPath(m)) can be simplified to .map(convertSlashesInPath)

demo/AngularApp/references.d.ts Outdated

@@ -0,0 +1,2 @@

/// <reference path="./node_modules/tns-platform-declarations/ios.d.ts" />

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link

Contributor Author

@vchimev vchimev Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of native API - otherwise, transpilation fails.

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast to any? I mean, it's a test app.

demo/JavaScriptApp/app/activity.android.js Outdated

@@ -0,0 +1,35 @@

let frame = require("ui/frame");

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

demo/JavaScriptApp/app/activity.android.js Outdated

@@ -0,0 +1,35 @@

let frame = require("ui/frame");

let superProto = android.app.Activity.prototype;

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

demo/JavaScriptApp/app/activity.android.js Outdated

let frame = require("ui/frame");

let superProto = android.app.Activity.prototype;

let Activity = android.app.Activity.extend("org.myApp.MainActivity", {

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const. Maybe it's not even needed to assign this to a variable.

demo/JavaScriptApp/app/application.android.js Outdated

@@ -0,0 +1,16 @@

var superProto = android.app.Application.prototype;

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

demo/JavaScriptApp/app/application.android.js Outdated

@@ -0,0 +1,16 @@

var superProto = android.app.Application.prototype;

// the first parameter of the `extend` call defines the package and the name for the native *.JAVA file generated.

var Application = android.app.Application.extend("org.myApp.Application", {

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for the activity

demo/TypeScriptApp/app/application.android.ts Outdated

@@ -0,0 +1,18 @@

// the `JavaProxy` decorator specifies the package and the name for the native *.JAVA file generated.

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comments.

xml-namespace-loader.js Outdated

const moduleRegisters = namespaces

.map(function (n) {

let obj = n;

Copy link

Contributor

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is not needed. Also extract that function.

This was referenced Jun 23, 2018

Snapshot Bundle failed with custom android activity #568

Closed

Nativescript 4.1.0 using custom main activity with webpack #559

Closed

uglify option prevent the generation of application java class. #564

Closed

@vchimev vchimev force-pushed the vchimev/component-resolve-windows branch 2 times, most recently from d84ce1b to 92415df Compare

June 25, 2018 11:01

sis0k0

sis0k0 approved these changes

Jun 25, 2018

View reviewed changes

vchimev and others added 17 commits

June 25, 2018 22:10

@vchimev


 fix: resolve appComponents absolute paths on Windows

ae1cceb

Fix #573.

@vchimev


 fix: resolve xml namespaces absolute paths on Windows

6e77f4b

@vchimev


 chore(JavaScriptApp): add webpack.config.js file

35112fc

Clean up npm scripts.

@vchimev


 test(JavaScriptApp): extend android application

b22ba3b

@vchimev


 test(JavaScriptApp): extend android activity

1677aac

@vchimev


 chore(TypeScriptApp): add webpack.config.js file

b42f16a

Clean up npm scripts.

@vchimev


 chore(TypeScriptApp): add platform declarations

0ed2c5a

@vchimev


 test(TypeScriptApp): extend android application

e9a1ea7

@vchimev


 test(TypeScriptApp): extend android activity

cdde491

@vchimev


 chore(AngularApp): add webpack.config.js file

24ff369

Clean up npm scripts.

@vchimev


 chore(AngularApp): add platform declarations

8c196ff

@vchimev


 test(AngularApp): extend android application

b271bbb

@vchimev


 test(AngularApp): extend android activity

ac6295c

@vchimev


 chore(AngularApp): update @angular/compiler-cli version

b31b5f0

@vchimev


 refactor(demos): minor tweaks

dc38afc

@vchimev


 chore(JavaScript): remove unused variables

f8aa3a9

@vchimev


 refactor: address comments

6a8fdad

vchimev added 3 commits

June 25, 2018 22:10

@vchimev


 chore(e2e): update application activity to launch

25de3d4

@vchimev


 refactor: remove tns-platform-declarations dependency

b8cd317

@vchimev


 chore(e2e): remove application activity from capabilities

bbb9716

The nativescript-dev-appium plugin gets it automatically, no need to declare it in the `appium.capabilities.json` file.

@vchimev vchimev force-pushed the vchimev/component-resolve-windows branch from aef8202 to bbb9716 Compare

June 25, 2018 19:10

@vchimev vchimev merged commit 14de7e1 into master

Jun 26, 2018

@RoyiNamir

Copy link

RoyiNamir commented Jul 2, 2018

@sis0k0 @vchimev
Hi.How can we know to which version is it merged to ?
I mean - say I want to use this merged fix - what should I install ? which version ?

@RoyiNamir RoyiNamir mentioned this pull request

Jul 2, 2018

Absolute path is not resolved in v0.14.2 when extending activity #592

Closed

@sis0k0

Copy link

Contributor

sis0k0 commented Jul 2, 2018

Hi, @RoyiNamir! For this plugin, usually the best place is the changelog.

@RoyiNamir

Copy link

RoyiNamir commented Jul 2, 2018 •

edited

Loading

@sis0k0 Hey :) Thanks for the info 👍 . (So I guess there's still a problem) after the merge .

@sis0k0

Copy link

Contributor

sis0k0 commented Jul 2, 2018

No problem :) We'll investigate the issue you opened.

@RoyiNamir RoyiNamir mentioned this pull request

Jul 3, 2018

Latest version problem with --bundle ddfreiling/tns-ng-deeplink#4

Closed

@vchimev vchimev deleted the vchimev/component-resolve-windows branch

December 17, 2018 16:01

Labels

None yet

3 participants

@vchimev @RoyiNamir @sis0k0

Uh oh!

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

Uh oh!

Conversation

@vchimev vchimev commented Jun 21, 2018

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@vchimev vchimev Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Jun 22, 2018

Choose a reason for hiding this comment

Uh oh!

RoyiNamir commented Jul 2, 2018

Uh oh!

sis0k0 commented Jul 2, 2018

Uh oh!

RoyiNamir commented Jul 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sis0k0 commented Jul 2, 2018

Uh oh!

Uh oh!

RoyiNamir commented Jul 2, 2018 •

edited

Loading