This repository was archived by the owner on Aug 7, 2021. It is now read-only.

chore: add changelog for the 0.10.0 release and steps for publishing #486

Merged

sis0k0 merged 6 commits into master from sis0k0/0.10

Apr 6, 2018

Merged

chore: add changelog for the 0.10.0 release and steps for publishing #486

sis0k0 merged 6 commits into master from sis0k0/0.10

Apr 6, 2018

Conversation

sis0k0

Copy link

Contributor

@sis0k0 sis0k0 commented Apr 5, 2018

Should be merged with rebase and merge.

sis0k0 added 3 commits

April 5, 2018 15:45

@sis0k0


 chore: add npm version script

5b39169

@sis0k0


 docs(CONTRIBUTING): add steps for publishing

2a12b24

@sis0k0


 chore: add dependency to conventional-changelog-cli

4bc7019

The package is used by the npm preversion script for generating
changelog.

vakrilov

vakrilov approved these changes

Apr 5, 2018

View reviewed changes

vchimev

vchimev reviewed

Apr 5, 2018

View reviewed changes

CONTRIBUTING.md

Thank you for your contribution!

## Publishing new versions

Copy link

Contributor

@vchimev vchimev Apr 5, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to TOC.

vchimev

vchimev reviewed

Apr 5, 2018

View reviewed changes

CONTRIBUTING.md

git checkout -b username/release-version

```

5. Run `npm version` to bump the version in the `package.json`, tag the release and update the CHANGELOG.md:

Copy link

Contributor

@vchimev vchimev Apr 5, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm version script does not create a tag - update it to do so or add it as an explicit step.

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does https://docs.npmjs.com/cli/version#description

jogboms

jogboms reviewed

Apr 6, 2018

View reviewed changes

CHANGELOG.md

After:

```

tns run android --bundle --env.snapshot --release --keyStorePath ~/path/to/keystore/my.keystore --keyStorePassword password --keyStoreAlias alias --keyStoreAliasPassword aliasPassword

```

Copy link

@jogboms jogboms Apr 6, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sis0k0 what if you only want to use Android studio for publishing packages instead of just the CLI?

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're stripping the --env.snapshot flag that you're passing to the CLI to prevent livesyncing with snapshot. However, you can edit your webpack config and enable the snapshot plugin from there - https://github.com/NativeScript/nativescript-dev-webpack/blob/master/templates/webpack.angular.js#L180.

Copy link

@jogboms jogboms Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I see. I can manage that in place of livesync 👍

sis0k0 added 3 commits

April 6, 2018 13:35

@sis0k0


 docs(CONTRIBUTING): add 'publishing new versions' to the table of con...

9cddb0f

...tents

@sis0k0


 fix-next: get properly project data from {N} CLI

02facf7

@sis0k0


 release: cut the 0.10.0 release

cb8da4f

@sis0k0 sis0k0 force-pushed the sis0k0/0.10 branch from c5b7b08 to cb8da4f Compare

April 6, 2018 10:38

@sis0k0 sis0k0 merged commit 3b03c76 into master

Apr 6, 2018

@sis0k0 sis0k0 deleted the sis0k0/0.10 branch

April 6, 2018 11:15

@jogboms jogboms mentioned this pull request

Apr 6, 2018

Why was Snapshot disabled on debug builds? #487

Closed

Labels

None yet

4 participants

@sis0k0 @vakrilov @jogboms @vchimev

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: add changelog for the 0.10.0 release and steps for publishing #486

chore: add changelog for the 0.10.0 release and steps for publishing #486

Uh oh!

Conversation

@sis0k0 sis0k0 commented Apr 5, 2018

Uh oh!

@vchimev vchimev Apr 5, 2018 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@vchimev vchimev Apr 5, 2018 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Apr 5, 2018

Choose a reason for hiding this comment

Uh oh!

@jogboms jogboms Apr 6, 2018 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Apr 6, 2018

Choose a reason for hiding this comment

Uh oh!

@jogboms jogboms Apr 6, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chore: add changelog for the 0.10.0 release and steps for publishing #486

chore: add changelog for the 0.10.0 release and steps for publishing #486

Uh oh!

Conversation

@sis0k0 sis0k0 commented Apr 5, 2018

Uh oh!

@vchimev vchimev Apr 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@vchimev vchimev Apr 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Apr 5, 2018

Choose a reason for hiding this comment

Uh oh!

@jogboms jogboms Apr 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

@sis0k0 sis0k0 Apr 6, 2018

Choose a reason for hiding this comment

Uh oh!

@jogboms jogboms Apr 6, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@vchimev vchimev Apr 5, 2018 •

edited

Loading

@vchimev vchimev Apr 5, 2018 •

edited

Loading

@jogboms jogboms Apr 6, 2018 •

edited

Loading