This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for platform specific mainSheet #268
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-bot
commented
Sep 2, 2017
Can one of the admins verify this patch?
4 similar comments
ns-bot
commented
Sep 2, 2017
Can one of the admins verify this patch?
ns-bot
commented
Sep 2, 2017
Can one of the admins verify this patch?
ns-bot
commented
Sep 2, 2017
Can one of the admins verify this patch?
ns-bot
commented
Sep 2, 2017
Can one of the admins verify this patch?
gabitoesmiapodo
commented
Oct 13, 2017
Can one of the admins verify this... um, no, I'm no bot.
Just to confirm I applied this on my current Nativescript Webpack config and works like a charm, it solved my 'Can't resolve './app.css'...' error, which I get all the time.
I would be good if someone could check this and if everything's OK, merge it.
ns-bot
commented
Oct 13, 2017
Can one of the admins verify this patch?
Just to mention the custom file system implementation in #290 should handle this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably one of the main reasons for the relatively common error Can't resolve './app.css' is when it's based on platform file. (e.g.
app.ios.cssandapp.android.css).This is to detect if the corresponding platform specific file is present and fallback to
app.cssotherwise.