@EddyVerbruggen,

Can you extract the common logic from the two loaders?

Hi @sis0k0, yes.. I can take one of these approaches, do you have a perference?

• Keep it as 2 files, add a 'superclass' and inherit as much as possible (I'd need to override 2 functions (traversePropertyElements and isStyleUrls) in each concrete class, as well as wire up prototype inheritance).
• Just use 1 plugin file and make those 2 functions work with both types (view and css).

I think the latter is less code and has better performance as it only needs to traverse the entire tree once.

I would suggest refactoring it into a single plugin which has two options obj: { resolveStylesUrls: boolean, resolveTemplateUrls: boolean }. If you have any problems, ping me in the community slack :)

A downside of not merging the PR as is, is that it will break backward compatibility as folks now have new nsWebpack.StyleUrlResolvePlugin({platform}) in their webpack.config. That would still work fine if we implement the first option I mentioned though. WDYT?

We can deprecate it and even remove it from the webpack config on postinstall.

Hi @sis0k0, I've just pushed a change to bring all this code back to 1 file, and offer the option to opt out of replacing either css or html files.

Looks good :). I'll add postinstall step to replace the old plugin in the user's webpack config.

Eddy, check out EddyVerbruggen#1 :)

Post install script works great ✅