This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
fix(ns-bundle): use remove/add platform instead of clean-app #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving old build files in the platform folders caused several issues. fixes 75, fixes 112
vchimev
vchimev
approved these changes
Apr 13, 2017
run ci
1 similar comment
run ci
ishitatsuyuki
commented
May 5, 2017
Is there any plans to make this unnecessary? Writing the platform again and again hurts my SSD (and it takes time for sure).
Yep, we'll be looking for a workaround. Just wondering, how often are you bundling your project with webpack? We assume, people do this only for release builds (since it has no livereload yet), but I'm curious if you're using it for development.
ishitatsuyuki
commented
May 5, 2017
Two cases:
- You don't want to destroy your SSD while investigating webpack config errors.
- Cache is ruined when doing both test and release build in CI.
Also, if I'm correct, this doesn't clean the things up after bundling right? It's probably causing a gradlew binding error then, starting from 3.0.
ishitatsuyuki
commented
May 5, 2017
I have opened #145 to track this case. Let's discuss there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Leaving old build files in the platform folders caused several issues.
fixes #75, fixes #112