This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
refactor: emit warning for invalid & in XML #1059
Merged
Merged
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vakrilov
vakrilov
force-pushed
the
sax-pareser-support-ampersant
branch
from
October 1, 2019 08:37
abb0c0a to
50a9ab6
Compare
manoldonev
manoldonev
approved these changes
Oct 1, 2019
DimitarTachev
DimitarTachev
approved these changes
Oct 1, 2019
nmandyam
commented
Nov 25, 2019
It is worrisome to see so many warnings about code that includes JS conditions ("a && b"). Is there a way we can hide these warnings during build?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
xml-namespace-loaderthrows error when encounters&in attribute value.What is the new behavior?
xml-namespace-loaderwill only emit warning in this case. Having&&in an attribute value might happen if you have a binding expression.