This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
feat: support V8 snapshots on Windows #1055
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Fatme
Fatme
approved these changes
Sep 26, 2019
@DimitarTachev
DimitarTachev
force-pushed
the
tachev/snapshot-on-windows
branch
from
September 27, 2019 13:29
7a8d017 to
3a687c0
Compare
Fatme
Fatme
approved these changes
Sep 27, 2019
test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Providing the
--env.snapshotflag on Windows is throwing an exception.What is the new behavior?
The
--env.snapshotflag is valid on Windows and it is generating snapshots in a docker container.Related to: https://github.com/NativeScript/nativescript-dev-webpack/issues/1054 and NativeScript/nativescript-cli#5037