Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: remove colors dependency #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vchimev wants to merge 2 commits into master from vchimev-colors
Closed

refactor: remove colors dependency #52

vchimev wants to merge 2 commits into master from vchimev-colors

Conversation

Copy link
Contributor

@vchimev vchimev commented Oct 22, 2017
edited
Loading

#51

Copy link
Contributor

SvetoslavTsenov commented Oct 23, 2017
edited by vchimev
Loading

Hey, @vchimev, can you try to fix the dependency. I think it is time to use it in our log for better visualization.
Here is an example of colors:

`
var colors = require('colors');

colors.setTheme({
info: 'blue',
data: 'grey',
help: 'cyan',
warn: 'yellow',
error: 'red'
});

// outputs red text
console.log("this is an error".error);

// outputs yellow text
console.log("this is a warning".warn);`

Basically, we can use red for errors, orange for warning, blue for basic info and etc. It is easy to use in our logs in utils.

vchimev reacted with thumbs up emoji

Copy link
Contributor Author

vchimev commented Nov 21, 2017

The colors dependency has been removed in #63.

@vchimev vchimev deleted the vchimev-colors branch November 21, 2017 15:37
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SvetoslavTsenov SvetoslavTsenov Awaiting requested review from SvetoslavTsenov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /