Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(renderer): order not preserved #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into NativeScript:master from edusperoni:renderer-ordering-fix
Sep 21, 2020

Conversation

@edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Sep 21, 2020
edited
Loading

PR Checklist

What is the current behavior?

Ordering can be erratic when nesting ng-containers and templates. This is due to previousSibling not being implemented and comment nodes not being properly respected

<ng-container>
 <Label text="1" *ngIf="show"></Label>
 <Label text="2" *ngIf="show"></Label>
</ng-container>

will render:

2
1

What is the new behavior?

The node list is now doubly linked (previousSibling and nextSibling), allowing for faster processing of previousSibling and respecting the positioning of commentnodes.

<ng-container>
 <Label text="1" *ngIf="show"></Label>
 <Label text="2" *ngIf="show"></Label>
</ng-container>

will render
1
2

Fixes/Implements/Closes #[Issue Number].

bellalMohamed reacted with thumbs up emoji bellalMohamed reacted with hooray emoji bellalMohamed reacted with heart emoji bellalMohamed reacted with rocket emoji
@NathanWalker NathanWalker merged commit 07abb9e into NativeScript:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /