Automatically Close Resources #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

pixeebot wants to merge 1 commit into main from pixeebot/drip-2024年11月02日-pixee-python/fix-file-resource-leak

Closed

Automatically Close Resources #8

pixeebot wants to merge 1 commit into main from pixeebot/drip-2024年11月02日-pixee-python/fix-file-resource-leak

Conversation

pixeebot[bot]

Copy link

@pixeebot pixeebot bot commented Nov 2, 2024

This codemod wraps assignments of open calls in a with statement. Without explicit closing, these resources will be "leaked" and won't be re-claimed until garbage collection. In situations where these resources are leaked rapidly (either through malicious repetitive action or unusually spiky usage), connection pool or file handle exhaustion will occur. These types of failures tend to be catastrophic, resulting in downtime and many times affect downstream applications.

Our changes look something like this:

import tempfile
path = tempfile.NamedTemporaryFile().name
-file = open(path, 'w', encoding='utf-8')
-file.write('Hello World')
+with open(path, 'w', encoding='utf-8') as file:
+ file.write('Hello World')