-
Notifications
You must be signed in to change notification settings - Fork 50
added example of github pushing to s3, using oidc - #295
Conversation
Kudos, SonarCloud Quality Gate passed! Quality Gate passed
Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells
No Coverage information No Coverage information
No Duplication information No Duplication information
@andyblundell
andyblundell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good - needs referencing from somewhere though, not sure there's anywhere suitable yet, maybe we need a new list of handy guides for specific stuff like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)
@amaanibn-nasar1-nhs
amaanibn-nasar1-nhs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting that I've done some work to create a reusable terraform module that does this. https://github.com/NHSDigital/ee-terraform-modules
No description provided.