-
Notifications
You must be signed in to change notification settings - Fork 339
Fix PointPlacemark pitch issue #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EMaksymenko
wants to merge
1
commit into
NASAWorldWind:develop
from
WorldWindEarth:fix/placemark-pitch
Open
Fix PointPlacemark pitch issue #241
EMaksymenko
wants to merge
1
commit into
NASAWorldWind:develop
from
WorldWindEarth:fix/placemark-pitch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent tilted PointPlacemark clipping (NASAWorldWind#151). Make rotation and tilting around specified offset point instead of image center.
@EMaksymenko
EMaksymenko
force-pushed
the
fix/placemark-pitch
branch
from
February 20, 2022 19:08
d68482b to
843d22f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description of the Change
This PR adds maximum diagonal size of placemark texture value into depth range of glOrtho, the similar way as CompassLayer do for Compass texture tilt.
It also fix rotation and tilting of PointPlacemark around specified offset point instead of rotation around center.
Why Should This Be In Core?
Bug should be fixed to make correct PointPlacemark tilt and rotation functionality.
Benefits
Placemarks will be correctly tilted and rotated without graphical glitches.
Potential Drawbacks
None.
Applicable Issues
#151