-
-
Notifications
You must be signed in to change notification settings - Fork 27
Comments
fix: add silence leave for premiumvanish#168
Open
ChipWolf wants to merge 1 commit intoMultiChat:master from
Open
fix: add silence leave for premiumvanish #168ChipWolf wants to merge 1 commit intoMultiChat:master from
ChipWolf wants to merge 1 commit intoMultiChat:master from
Conversation
Contributor
@akshualy
akshualy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change comment & should be fine.
@ChipWolf
ChipWolf
force-pushed
the
master
branch
from
February 26, 2021 23:58
a89e9af to
a3360ed
Compare
Author
ChipWolf
commented
Mar 31, 2021
@OllieMartin ready for you to merge
Author
ChipWolf
commented
Apr 28, 2021
@Gadsee do you have merge access?
@ChipWolf
ChipWolf
force-pushed
the
master
branch
from
April 28, 2021 22:45
a3360ed to
e10cfcc
Compare
@ChipWolf
ChipWolf
changed the title
(削除) feat: add silence leave for premiumvanish (削除ここまで)
(追記) fix: add silence leave for premiumvanish (追記ここまで)
Apr 28, 2021
@ChipWolf
ChipWolf
force-pushed
the
master
branch
from
April 28, 2021 22:47
e10cfcc to
690aa7d
Compare
@ChipWolf
ChipWolf
force-pushed
the
master
branch
from
April 28, 2021 22:48
690aa7d to
1ddeb28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
What, briefly, is the purpose of this pull request?
Adds functionality to silence leave messages if the user is vanished with PremiumVanish.
Is this pull request related to an issue with the plugin?
Fixes #167
What is the status of this pull request? [e.g. In Development, Undergoing Final Testing, Ready]
Ready for merge
Changes
What currently existing parts of the plugin are affected by this pull request
If users vanish with PremiumVanish, it sends a fake leave message. If they then leave the server, there's another leave message. Users which are vanished with PremiumVanish cannot leave incognito.
What new features are added to the plugin by this pull request
An option to silence leave messages if a user is vanished with PremiumVanish.
Standards
Does this pull request adhere to basic Java coding standards?
I matched the standard of the existing code implemented to silence the join messages.
Does this pull request seem to stay true to the style used so far in the MultiChat code.
Yes, it's essentially a copy and paste job :)