-
Notifications
You must be signed in to change notification settings - Fork 7
fix: quiet startup output and add persistent linked indicator#35
Merged
Merged
Conversation
Bare `mobilecli` previously printed a wall of info-level tracing logs plus a "Connected!" banner just before tmux entered its alternate screen, so users saw a brief flash of text and then a normal shell prompt with no visible indication that streaming was active. Three coordinated changes restore a calm, discoverable UX: - Default tracing filter drops from `mobilecli=info` to `mobilecli=warn`. Operators still get RUST_LOG overrides. - The pty wrapper sets the host terminal window title to "📱 MobileCLI · <session>" via OSC 0 at session start and clears it on exit. The title survives tmux's alt-screen takeover, so the linked state is always visible in the emulator's title bar. - A one-line hint pointing at `mobilecli help` is shown only when bare `mobilecli` is run from an interactive terminal, giving newcomers a pointer to the rest of the command surface without crowding power- user invocations like `mobilecli claude`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bare
mobileclipreviously printed a wall of info-level tracing logs plus a "Connected!" banner just before tmux entered its alternate screen, so users saw a brief flash of text and then a normal shell prompt with no visible indication that streaming was active. A user emailed support today reporting they couldn't tell if anything had happened after pairing.Three coordinated changes restore a calm, discoverable UX:
cli/src/main.rs): default drops frommobilecli=infotomobilecli=warn.RUST_LOGoverrides still work for operators who want verbose output.cli/src/pty_wrapper.rs): set the host terminal window title to📱 MobileCLI · <session>via OSC 0 at session start and clear it on exit. The title survives tmux's alt-screen takeover, so the linked state is always visible in the emulator's title bar.cli/src/main.rs): one-line→ Tip: run \mobilecli help` ...shown only when baremobilecliis run from an interactive TTY, giving newcomers a pointer to the rest of the command surface without crowding power-user invocations likemobilecli claude`.Includes the version bump to 0.2.1 so this PR can be tagged and released directly after merge.
Test plan
cargo build --releasecargo test --release— 74 passed, 0 failedcargo fmt --checkcargo clippy --all-targets -- -D warnings -A dead-code🤖 Generated with Claude Code