-
Notifications
You must be signed in to change notification settings - Fork 232
Open
Conversation
Author
James23rc
commented
Oct 5, 2023
Contributor
Hello James23rc,
Thanks for your valid point out. I acknowledged your commit.
However, I have little worries about hardcoding the numbers such as /4096, /8. (I know /4096 things are we did, but still)
So I'm considering not to take your commit, at the moment.
Please see the reason below.
Size of the page in SSD is also a configurable parameter(Scalability)
and hardcoding such as ( lba / 8 ) hinders understanding the code.(Code visibility)
Using macro something like this is better, this is just an example
#define _4KB 4096
#define LBA_TO_LPN (SSD_PAGE_SIZE / HOST_LBA_SIZE)
Again, appreciate for your commit, we will reflect your point soon :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size of a page is 4096 bytes, which is 8 * 512 bytes, not 4096 * 512 bytes(which is 2MB).