-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
There is no verification if host supports huge pages. There is no verification of any kind of libvirt/qemu configuration if it's needed for huge pages. There is no validation of nodeset value at the moment. Simply if there is VirtletHugePages annotation its value is used to construct data in memoryBacking section of libvirt domain xml (according to https://libvirt.org/formatdomain.html#elementsMemoryBacking) Whole value is split to sub entries using ";" as separator. Each entry should have 3 values, * size - as a uint * unit - single character denoting unit size (K, M, or G) * nodeset - node ranges (e.g. 0-3), or/and particular node numbers of numa nodes, combined with comma sign (please refer to libvirt docs for details - this part is passed "as is" to domain definition).
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There is no verification if host supports huge pages.
There is no verification of any kind of additional libvirt/qemu configuration if it's needed for huge pages.
There is no validation of nodeset value at the moment.
Simply if there is VirtletHugePages annotation its value is used to
construct data in memoryBacking section of libvirt domain xml
(according to https://libvirt.org/formatdomain.html#elementsMemoryBacking).
Whole value is split to sub entries using ";" as separator.
Each entry should have 3 values:
numa nodes, combined with comma sign (please refer to libvirt docs for
details - this part is passed "as is" to domain definition).
This change is Reviewable