-
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Conversation
Jonathing
Jonathing
approved these changes
Mar 22, 2025
try {
return Files.list(services)
try (var servicesDirStream = Files.list(services)) {
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this had issues with Zip file systems, calling close anywhere on them caused the entire thing to shut down.
LexManos
LexManos
approved these changes
Mar 22, 2025
Jonathing
commented
Apr 6, 2025
Member
If tests are passing for this, I think this is good to be merged. Keep in mind Lex's comment regarding issues with zip file systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of small non-breaking changes.