-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update sp-help-spatial-*-histogram-transact-sql.md #10244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sommarskog : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.
|
Learn Build status updates of commit e03a284 : ✅ Validation status: passed
For more details, please refer to the build report. |
Corrected the required permission based on the actual behaviour, although this has to be construed as a bug. That is, you don't get an explicit permission error, but only "A severe error occurred on the current command. The results if any should be discarded". Given how long this behaviour has been there, fixing the actual bug is unlikely to pass the triage bar. Thus, better to adopt the documentation.
e03a284 to
54b0d42
Compare
|
Learn Build status updates of commit 54b0d42 : ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request corrects the documented permissions requirements for two spatial histogram stored procedures to reflect actual behavior. The procedures require sysadmin role membership rather than public role with READ ACCESS permissions as previously documented.
Key Changes
- Updated permission requirements in both
sp_help_spatial_geometry_histogramandsp_help_spatial_geography_histogramdocumentation - Changed from "public role with READ ACCESS" to "sysadmin fixed server role"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sp-help-spatial-geometry-histogram-transact-sql.md | Corrected Permissions section to require sysadmin role |
| sp-help-spatial-geography-histogram-transact-sql.md | Corrected Permissions section to require sysadmin role |
ttorble
commented
Dec 8, 2025
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team
rwestMSFT
commented
Dec 8, 2025
#reassign:rwestMSFT
rwestMSFT
commented
Dec 15, 2025
@sommarskog We're discussing this internally. In the meantime I combined both your PRs into one. It might take some time for an outcome due to the holiday period.
Corrected the required permission based on the actual behaviour, although this has to be construed as a bug. That is, you don't get an explicit permission error, but only "A severe error occurred on the current command. The results if any should be discarded". Given how long this behaviour has been there, fixing the actual bug is unlikely to pass the triage bar. Thus, better to adopt the documentation.