-
Notifications
You must be signed in to change notification settings - Fork 645
Comments
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 94.98%. Comparing base (
4cd200d) to head (ef523a6).
Additional details and impacted files
@@ Coverage Diff @@ ## main #3173 +/- ## ======================================= Coverage 94.98% 94.98% ======================================= Files 511 511 Lines 11313 11313 Branches 1741 1741 ======================================= Hits 10746 10746 Misses 567 567
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
Outdated
Show resolved
Hide resolved
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
Outdated
Show resolved
Hide resolved
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the JSDoc too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use this naming instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, updated: 98d4964
Added a method to show require scroll content to allow for e2e testing of the new
requireScrollfooter prop.