-
-
Notifications
You must be signed in to change notification settings - Fork 276
Comments
chore: add deprecation notices to the AccountsController#8027
Merged
chore: add deprecation notices to the AccountsController #8027
AccountsController #8027Conversation
mathieuartu
mathieuartu
approved these changes
Feb 24, 2026
gantunesr
gantunesr
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Explanation
The
AccountsControllerwill soon be phased out and so deprecation notices are being added across the class, methods and types to discourage use and inform of the new way of interacting with accounts.References
N/A
Checklist
Note
Low Risk
Doc-only changes (JSDoc
@deprecatedannotations and changelog entry) with no runtime behavior changes; risk is limited to consumers treating deprecations as warnings/errors in stricter builds.Overview
Marks
AccountsControlleras deprecated across the package by adding JSDoc@deprecatedannotations to the class,EMPTY_ACCOUNT, exported action/event/state types, and key public methods (e.g.,getAccount,listMultichainAccounts,updateAccounts,loadBackup).Updates the
accounts-controllerchangelog to announce the deprecation and point consumers toAccountTreeController,MultichainAccountService, and Keyring API v2.Written by Cursor Bugbot for commit 3e3f768. This will update automatically on new commits. Configure here.