-
-
Notifications
You must be signed in to change notification settings - Fork 275
Comments
Open
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
@milos-ethernal
milos-ethernal
changed the title
(削除) Custom token balances fix (削除ここまで)
(追記) fix: custom token balances (追記ここまで)
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Explanation
At this moment the custom token balances on chains like Base and BNB are not showing correct token amounts on MetaMask token section. I traced the error to
Screenshot from 2026年02月06日 13-13-22 Screenshot from 2026年02月06日 13-17-34 Screenshot from 2026年02月06日 13-17-42 Screenshot from 2026年02月06日 13-17-51TokenBalancesControllerwhere AccountsAPI fetcher returns balances but misses custom tokens. The controller now detects this and triggers an RPC fallback for those specific tokensThis change fixes the problem that I was facing on Base and BNB chains
References
This fixes the problem that I faced and submitted the ticket #74726250 to Technical Support
Checklist
Note
Medium Risk
Touches core balance-fetch selection/fallback logic; incorrect detection could increase RPC traffic or still miss balances on some chains/accounts.
Overview
Fixes cases where
TokenBalancesControllerrelies on Accounts API results that omit custom token balances by detecting missing token/account entries and re-adding those chain IDs to the RPC fallback path.Adds a regression test ensuring custom token balance fetching respects
queryAllAccounts(only queried accounts are fetched in single-account polling; all accounts are fetched when enabled), and updates the changelog accordingly.Written by Cursor Bugbot for commit e7d23f8. This will update automatically on new commits. Configure here.