-
Notifications
You must be signed in to change notification settings - Fork 5
Resolving transaction conflicts in the discovery domain#858
Draft
aryanjassal wants to merge 1 commit intostaging from
Draft
Resolving transaction conflicts in the discovery domain #858aryanjassal wants to merge 1 commit intostaging from
aryanjassal wants to merge 1 commit intostaging from
Conversation
Contributor
Author
aryanjassal
commented
Jan 17, 2025
When I applied a simple change of properly extracting the gestaltIdEncoded from an array, the syncNodeGraphHandler fails. And this change still has the DBTransactionConflict. So I would need to do a bit more research to actually resolve this.
pid 933361
nodeId vet1dhoduhkmn4749r8usiopivklr8i4qoh9kjnhtgeg5rie4nvh0
clientHost ::1
clientPort 38573
agentHost ::
agentPort 39793
WARN:polykey.PolykeyAgent.task v0ps9qrcqapo01bq69ce6vhp398:Failed - Reason: ErrorNodeManagerSyncNodeGraphFailed("Failed to establish any connections with the following errors '[ErrorNodeConnectionTimeout()>AggregateError: All promises were rejected,ErrorNodeConnectionTimeout()>AggregateError: All promises were rejected]'")>AggregateError, Handler: NodeManager.syncNodeGraphHandler
WARN:polykey.PolykeyAgent.task v0ps9qihjq9o01a3rgl422osjhc:Failed - Reason: ErrorDBTransactionConflict, Handler: Discovery.checkForRediscoveryHandler
@aryanjassal
aryanjassal
force-pushed
the
feature-discovery-transaction-conflict
branch
from
January 17, 2025 05:33
263b3df to
2ee8f16
Compare
Contributor
Author
aryanjassal
commented
Jun 19, 2025
This PR is more like a template or a starting point, so a simple rebase on staging and work can be resumed in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Occasionally, a
ErrorDBTransactionConflictis omitted from a background taskcheckForRediscoveryHandler. This should be properly locking a transaction and concurrent modification should be impossible.This PR aims to figure out and eradicate the cause for this warning.
Issues Fixed
ErrorDBTransactionConflictif the agent is left running for a while Polykey-CLI#353 (REF ENG-511)Tasks
ErrorDBTransactionConflictinDiscovery.checkForRediscoveryHandlerFinal checklist