Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump versions to avoid Node 12 deprecation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarketingPip merged 1 commit into MarketingPipeline:main from yaiir-a:patch-1
Dec 22, 2022
Merged

Bump versions to avoid Node 12 deprecation #2

MarketingPip merged 1 commit into MarketingPipeline:main from yaiir-a:patch-1
Dec 22, 2022

Conversation

Copy link
Contributor

@yaiir-a yaiir-a commented Dec 21, 2022

Running using actions/checkout@v2, actions/setup-python@v2 gives the following deprecation warning:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

MarketingPip reacted with thumbs up emoji MarketingPip reacted with hooray emoji MarketingPip reacted with heart emoji
Running using actions/checkout@v2, actions/setup-python@v2 gives the following deprecation warning:
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
@MarketingPip MarketingPip merged commit 0a46744 into MarketingPipeline:main Dec 22, 2022
Copy link
Member

@yaiir-a - good catch! I completely forgot to update this earlier! Thank you for making this pull request - PR has been merged. 🥳

Open source community is so lucky to have a great people like yourself to improve the life's of developer's!

So thank you once again! And feel free to add any further contributions, as they are more than appreciated. ❤️

yaiir-a reacted with heart emoji

Copy link
Contributor Author

yaiir-a commented Dec 22, 2022

It's the least I could do :)

God knows how much time this one little line saved me:
- name: Install xvfb
run: sudo apt-get install xvfb

MarketingPip reacted with thumbs up emoji MarketingPip reacted with heart emoji

Copy link
Member

It's the least I could do :)

God knows how much time this one little line saved me:

 - name: Install xvfb
 run: sudo apt-get install xvfb

Don't know how I missed responding to this! And trust me I know! It took how many hours it took me to figure it out alone so, I couldn't bare to make someone else go through that pain! 😂

Again thank you for your contribution on making it / the repo better. Hope all is well! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /