Add return type to PoolAcquireContext.aenter and rename attribute #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

TerSent wants to merge 1 commit into MagicStack:master

Open

Conversation

Copy link

Improves type inference in async with pool.acquire() by:

Adding -> connection.Connection return type to PoolAcquireContext.__aenter__
Renaming internal attribute self.connection to self._conn to avoid confusion and help type checkers

Without this change, type checkers (mypy, pyright, pylance) cannot correctly infer the type of the connection in:

async with pool.acquire() as conn:
 await conn.fetchrow("SELECT 1") # ← conn has type 'Unknown' or 'Any'


 Add return type to PoolAcquireContext.__aenter__ and rename internal ...

c533288

...attribute