-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Conversation
ilesinge
marked this pull request as ready for review
December 12, 2022 18:57
Bomme
Bomme
reviewed
Dec 13, 2022
@Bomme
Bomme
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ilesinge for this PR!
@ffont
ffont
changed the title
(削除) Package with Poetry (削除ここまで)
(追記) Package for Pypi (追記ここまで)
Dec 19, 2022
ffont
commented
Dec 19, 2022
Member
Hi @Bomme @ilesinge , I was to merge that and go ahead with publishing but the workflow for testing the package fails. I tried to fix but I'm a bit confused. Sorry I don't have a lot of experience publishing in pypi, but:
- The error seems to be related to
packages = [{include = "freesound.py"}]not doing its job as it tries also to add the other files (the example and download_bookmarks_example). - If we're not using poetry now, why are there references to poetry in
pyproject.otml? Is this something to be fixed?
Thanks for your help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #5