Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

libs version update to support latest android studio #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@parmeshtoyou parmeshtoyou commented Sep 29, 2024

Hi Lukas,
After purchasing the course from udemy, i tried building your branch but it was not succeeded due to Android studio version update.
I have updated required libraries, gradle version and able to build the code on latest android version.

Android Studio Ladybug Feature Drop | 2024年2月2日 Canary 4
Build #AI-242.23339.11.2422.12417746, built on September 26, 2024

Please review the changes and we can either keep these code in a new branch or update the existing one.

This will save other new devs time.

Thanks for this course.

Copy link

cavega commented Oct 5, 2024

@parmeshtoyou I ran into this same issue yesterday and updated the tools in my local branch.

@LukasLechnerDev It would be very helpful for future students to be able to clone the project and be up-and-running building the project. Would you be able to review this PR created by @parmeshtoyou? Thanks.

parmeshtoyou reacted with heart emoji

Copy link
Owner

Thank you @parmeshtoyou for your contribution 💪

Could you please:

  • Address the one comment that I wrote
  • merge master into this MR (I fixed the pipeline)

Then I think we can merge it!

parmeshtoyou reacted with thumbs up emoji cavega reacted with heart emoji

Copy link
Contributor Author

@LukasLechnerDev can we merge this PR? Provided comment addressed.

@LukasLechnerDev LukasLechnerDev merged commit fd7602e into LukasLechnerDev:coroutines_course_empty Nov 8, 2024
1 check passed
Copy link
Owner

Its merged! Thank you so much for your effort @parmeshtoyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasLechnerDev LukasLechnerDev LukasLechnerDev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /