-
-
Notifications
You must be signed in to change notification settings - Fork 376
fix: return empty response to textDocument/formatting if no changes #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sumneko
merged 2 commits into
LuaLS:master
from
danielleontiev:text-document-format-no-changes
Apr 5, 2025
Merged
fix: return empty response to textDocument/formatting if no changes #3142
sumneko
merged 2 commits into
LuaLS:master
from
danielleontiev:text-document-format-no-changes
Apr 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not send "edits" if the content remains unchanged after LSP formatting. Otherwise, Neovim reports an unsaved buffer even when no actual changes were made
@danielleontiev
danielleontiev
force-pushed
the
text-document-format-no-changes
branch
from
March 30, 2025 14:31
7ea9e7c to
aa273e3
Compare
@danielleontiev
danielleontiev
changed the title
(削除) feat: return empty response to textDocument/formatting if no changes (削除ここまで)
(追記) fix: return empty response to textDocument/formatting if no changes (追記ここまで)
Mar 30, 2025
@Copilot
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that no edits are sent when the LSP formatting results in no content changes, preventing Neovim from marking buffers as unsaved.
- Updated changelog entry documenting the fix
- Clarified behavior of textDocument/formatting
Files not reviewed (1)
- script/core/formatting.lua: Language not supported
Thank you!
@danielleontiev
danielleontiev
deleted the
text-document-format-no-changes
branch
April 5, 2025 08:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not send "edits" if the content remains unchanged after LSP formatting. Otherwise, Neovim reports an unsaved buffer even when no actual changes were made