-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Conversation
Remove the unused DropOldest slow-path option and publish QueuePolicy through a stable header and logging macros. Add an include-contract test for the public queue policy type.
Keep QueuePolicy owned by the loggers module umbrella and expose it through the unified public entry point. Remove the standalone leaf header and include-contract test so the documented header policy does not promise unsupported direct inclusion.
Verify that the supported logit/loggers.hpp entry point exports the public QueuePolicy alias without requiring a standalone leaf header.
Use the public QueuePolicy alias in logger configuration and constructor signatures while keeping the underlying enum implementation-owned. Clarify the aggregate-first header contract, document MPSC DropOldest semantics, and fix the queue policy example indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
LOGIT_ENABLE_DROP_OLDEST_SLOWPATHCMake optionlogit::QueuePolicythrough the supported<logit.hpp>and<logit/loggers.hpp>umbrella headersQueuePolicy.hppcontractDropOldestsemantics and the supported header policyValidation
This is intentionally separate from the documentation work in #125 and packaging dependency reuse in #127.