Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add id doc approver workflow#6891

Merged
vitormattos merged 25 commits intomain from
feat/add-id-doc-approver-workflow
Feb 16, 2026
Merged

feat: add id doc approver workflow #6891
vitormattos merged 25 commits intomain from
feat/add-id-doc-approver-workflow

Conversation

@vitormattos
Copy link
Member

@vitormattos vitormattos commented Feb 16, 2026

No description provided.

- Added optional signersCount field to ValidateFile response type definition
- Updated OpenAPI schema to include signersCount in validation responses
- Allows API consumers to get signer count without additional requests
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Removed initial empty visibleElements assignment to prevent incorrect API responses
- visibleElements now only appears in output when explicitly requested via showVisibleElements()
- Fixes test assertions for file visibility settings
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Modified canRequestSign() method to pass user UID string to getUserGroupIds()
- Modified isApprover() method to pass user UID string instead of IUser instance
- Aligns with IGroupManager method signature expectations
- Ensures proper group membership validation for approval workflows
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Updated getIdentificationDocumentsStatus() to pass user UID string instead of IUser instance
- Properly calls getUserGroupIds() with string parameter following IGroupManager interface
- Consistent with AccountSettingsProvider parameter handling
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Modified FileResponseOptions for approver workflow compatibility
- Updated FolderService for ID-doc approval handling
- Enhanced RequestSignatureService for dynamic signer requirements
- Updated SignFileService to support approver-based signature workflows
- Maintains backward compatibility with existing signature flows
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced IdDocsService to handle ID document approval workflows
- Updated AccountService to track approval-pending documents
- Integrated identification document status in account settings
- Supports both approval and standard document validation flows
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced AbstractIdentifyMethod with approver detection logic
- Updated IdentifyService to check if user is an approver
- Enables dynamic identification document requirement based on role
- Maintains compatibility with existing identification methods
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced ValidateHelper to support approval-pending document validation
- Added checks for approver status in validation workflows
- Improved error handling for identification document validation
- Supports both immediate and deferred validation scenarios
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced FileController to handle approver document validation
- Updated FileProgressController for approval workflow tracking
- Modified SignFileController to support approver-initiated signatures
- Ensures proper authorization and status tracking throughout signature flow
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced IdDocsController to support approver workflows
- Updated PageController to load approver context
- Modified LibresignTrait with common approver handling logic
- Provides unified approach to approver identification across controllers
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced File entity to support approver-related metadata
- Updated FileMapper with approver document queries
- Modified IdDocsMapper for approval status tracking
- Maintains referential integrity for approval workflows
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Extended FileStatus enum to support approval-related statuses
- Updated InjectionMiddleware with approver service injection
- Enhanced RequireSignRequestUuid attribute for approval contexts
- Improves request lifecycle handling for approval workflows
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced RequestSigningProgress with approver status tracking
- Modified RequestSignatureTab to support approver workflow management
- Updated RightSidebar component with approver-specific options
- Improves user experience for approval workflows in frontend
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Updated AccountSettingsProviderTest mock setup for approver checking
- Fixed SettingsLoaderTest expectations for approval group validation
- Corrected FileServiceTest assertions for visibleElements behavior
- Enhanced SignFileServiceTest parameter passing for service injection
All unit tests now properly validate the approver workflow implementation.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Updated identificationDocument store test to verify waiting approval state
- Fixed FileRequestFlow component test for sidebar visibility logic
- Enhanced logger test mock setup for proper factory pattern initialization
All frontend tests now pass with correct approver workflow behavior.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Created IdDocsPolicyService to manage approval policies
- Implemented UuidResolverService for UUID-based document lookups
- Enables flexible policy enforcement in approver workflows
- Supports both synchronous and deferred approval scenarios
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced identificationDocument store to track waiting approval state
- Updated sidebar store for approver context visibility
- Modified sign store to handle approver-initiated signature flows
- Provides centralized state management for approval workflows
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced Request.vue with approver document picker support
- Updated SignPDF component to handle approver signing flow
- Modified Sign.vue partial for approval context awareness
- Improved Validation.vue with approval status display
- Enhanced Documents.vue for account-level document management
- Updated IdDocsValidation.vue for approval workflow handling
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced Signer component to show approver status indicators
- Modified SidebarToggle for approver-specific visibility rules
- Updated constants.js with approval workflow configuration
- Improves approver identification and workflow management in UI
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Fixed ValidateHelperTest to verify approval document validation
- Updated InjectionMiddlewareTest for service injection changes
- Enhanced FolderServiceTest for approval-aware folder operations
- Modified IdentifyServiceTest to check approver identification
Ensures complete test coverage for approver workflow implementation.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Enhanced sidebar store tests for visibility management
- Updated OpenAPI TypeScript types to include signersCount field
- Generated type definitions from updated OpenAPI schema
- Ensures type safety for approver workflow components
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Added a file-UUID fallback to RequireSignRequestUuid handling and
allowed /p/pdf routes to use file UUIDs without sign request context.
This restores public validation access for file UUID links and fixes
validate.feature:26 integration scenario.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Remove unnecessary fallback logic by eliminating RequireSignRequestUuid
middleware from getPdf() route which was designed to accept file UUIDs
directly. The route uses accountService.getPdfByUuid() that already
handles file UUID lookups without needing sign request validation.
Removed:
- loadFileFromUuid() method (unused)
- allowFileUuid parameter from attribute
- try-catch fallback in middleware
The simplified solution maintains the same functionality while
reducing code complexity.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Copy link
Member Author

/backport to stable33

backportbot-libresign[bot] reacted with thumbs up emoji backportbot-libresign[bot] reacted with hooray emoji backportbot-libresign[bot] reacted with eyes emoji

Copy link
Member Author

/backport to stable32

backportbot-libresign[bot] reacted with thumbs up emoji backportbot-libresign[bot] reacted with hooray emoji backportbot-libresign[bot] reacted with eyes emoji

@vitormattos vitormattos merged commit be1b391 into main Feb 16, 2026
67 of 70 checks passed
@vitormattos vitormattos deleted the feat/add-id-doc-approver-workflow branch February 16, 2026 14:33
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /