-
-
Notifications
You must be signed in to change notification settings - Fork 126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5a36d8218
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Preserve topPad offset when selecting active sticky header
Clamping scroll to 0 here discards the negative scroll range that calculateItemsInView deliberately uses after subtracting topPad (headerSize + stylePaddingTop). With any non-zero top inset (for example ListHeaderComponent or top padding), the viewport is expected to remain in negative item-space until that inset is scrolled away; forcing 0 makes index 0 look active immediately, so the first sticky header enters sticky mode too early on web and can overlap visible header/padding content.
Useful? React with 👍 / 👎.
On the web, the sticky header did not take the padding into account before it was marked as
positon: sticky. This fixes that and now the header properly goes into sticky mode with the correct scroll offset.