Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add elixir as a language option #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThatHurleyGuy wants to merge 1 commit into LeetCode-OpenSource:master
base: master
Choose a base branch
Loading
from ThatHurleyGuy:add-elixir

Conversation

Copy link

@ThatHurleyGuy ThatHurleyGuy commented Aug 31, 2021
edited
Loading

I saw that elixir was now supported in the leetcode web UI, and thought it would be nice to be able to do that within vscode. This PR basically just adds elixir anywhere else that has boilerplate for other languages. I wasn't sure the best way to test this, so I deleted ~/.vscode/extensions/leetcode.vscode-leetcode-0.18.0/out and ~/.vscode/extensions/leetcode.vscode-leetcode-0.18.0/node_modules/vsc-leetcode-cli and replaced the contents with my forked repos. After that I was able to set my default language and generate/test/submit problems all in elixir.

This work will depend on an update the the cli repo dependency. See associated PR here. So we'll need to update that dependency once the other PR is merged/released. If there's anything missing from this PR or if there's anything else I can provide to help with this!

koyo-miyamura and jarlah reacted with thumbs up emoji
Copy link

@Weilet Weilet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

jarlah commented Jan 15, 2025
edited
Loading

can we get this merged? this is so simple, if its the only thing needed ..... i wouldn't even call this necroing .. this is just .. unnecessary :D

Copy link

jarlah commented Jan 15, 2025

all in all .. this stops me from using this extension . no elixir. No leetcode. I dont want to fiddle around with leetcode-cli. I even see that also lacks elixir ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Weilet Weilet Weilet left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /