Jul 23, 2020 · Jul 22, 2020 · Jul 22, 2020 · Jul 23, 2020 · Jul 22, 2020 · Jul 22, 2020
diff --git a/src/leetCodeExecutor.ts b/src/leetCodeExecutor.ts
diff --git a/src/shared.ts b/src/shared.ts
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,7 +8,7 @@ import * as path from "path";
		import * as requireFromString from "require-from-string";
		import { ExtensionContext } from "vscode";
		import { ConfigurationChangeEvent, Disposable, MessageItem, window, workspace, WorkspaceConfiguration } from "vscode";
	import { Endpoint, globalStateLeetcodeIsUserFresh, IProblem, supportedPlugins } from "./shared";
	import { Endpoint, globalStateLeetcodeHasInited, IProblem, supportedPlugins } from "./shared";
		import { executeCommand, executeCommandWithProgress } from "./utils/cpUtils";
		import { DialogOptions, openUrl } from "./utils/uiUtils";
		import * as wsl from "./utils/wslUtils";
Expand Down Expand Up		@@ -37,8 +37,8 @@ class LeetCodeExecutor implements Disposable {
		}

		public async meetRequirements(context: ExtensionContext): Promise<boolean> {
	const isUserFresh: boolean \| undefined = context.globalState.get(globalStateLeetcodeIsUserFresh);
	if (isUserFresh !== false) {
	const hasInited: boolean \| undefined = context.globalState.get(globalStateLeetcodeHasInited);
	if (!hasInited) {
		await this.removeOldCache();
Copy link Member @jdneo jdneo Jul 22, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Reuse the command we have? https://github.com/LeetCode-OpenSource/vscode-leetcode/blob/master/src/extension.ts#L51 Copy link Contributor Author @yihong0618 yihong0618 Jul 22, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Seems a little different.The command way use leetcode-cli way not delete the whole dir, let me check if it works fine too. Copy link Contributor Author @yihong0618 yihong0618 Jul 22, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @jdneo delete cache only delete the user session but not the plugin.js cache, still have that issue. So I think we can not use it.. image Copy link Member @jdneo jdneo Jul 22, 2020 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Maybe we need to change the implementation of the command `delete cache`. Considering that the current implementation does not clean entirely? Copy link Contributor Author @yihong0618 yihong0618 Jul 22, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Yes, current one only clean the user info(include session), but we change the `delete cache` also have one problem beacuse user may have two account one leetcode one leetcode-cn, if we change that. both will clean, but user may only want to clean the current cache. Copy link Member @jdneo jdneo Jul 22, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I see. So let's keep the implementation. Maybe later we can provide two option in this command. Something like `Session` and `All`. Anyway it's not a high priority
		}
		if (this.nodeExecutable !== "node") {
Expand Down Expand Up		@@ -66,12 +66,13 @@ class LeetCodeExecutor implements Disposable {
		for (const plugin of supportedPlugins) {
		try { // Check plugin
		await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "plugin", "-e", plugin]);
	} catch (error) { // Download plugin and activate
	} catch (error) { // Remove old cache that may cause the error download plugin and activate
		await this.removeOldCache();
		await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "plugin", "-i", plugin]);
		}
		}
	context.globalState.update(globalStateLeetcodeIsUserFresh, false);
	// Set the global state HasInited true to skip delete old cache after init
	context.globalState.update(globalStateLeetcodeHasInited, true);
		return true;
		}

Expand All		@@ -84,7 +85,7 @@ class LeetCodeExecutor implements Disposable {
		}

		public async signOut(): Promise<string> {
	return await await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "user", "-L"]);
Copy link Contributor Author @yihong0618 yihong0618 Jul 22, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. It seems that its an old typo so I changed it too, am I right? Copy link Member @jdneo jdneo Jul 23, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. yes
	return await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "user", "-L"]);
		}

		public async listProblems(showLocked: boolean): Promise<string> {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -115,4 +115,4 @@ export enum DescriptionConfiguration {
		None = "None",
		}

	export const globalStateLeetcodeIsUserFresh: string = "leetcode.isUserFresh";
	export const globalStateLeetcodeHasInited: string = "leetcode.isUserFresh";
Copy link Member @jdneo jdneo Jul 23, 2020 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Please also change the value. No need to have the prefix `globalState` I think. Since when you calling the API, that API name already tells it's a global state Copy link Contributor Author @yihong0618 yihong0618 Jul 23, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Got it~! Copy link Contributor Author @yihong0618 yihong0618 Jul 23, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Fixed.