-
Notifications
You must be signed in to change notification settings - Fork 676
add: star command in shortcuts #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @yihong0618
I would suggest to use $(star-empty) and $(star-full). You can find the style here: https://microsoft.github.io/vscode-codicons/dist/codicon.html
Ok, given the current rendering result, seems using text is better. But I think there is no need to put it as one of the default value
Ok, given the current rendering result, seems using text is better. But I think there is no need to put it as one of the default value
Maybe in setting that user can config it open it or not?
Do you mean using a setting to toggle between text and icon?
Do you mean using a setting to toggle between text and icon?
Forget it, I think for now, keep the text maybe a better way.
I think so too.
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this shortcut by default. But please add it in the items, and also documents in readme
@jdneo Fixed.
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unstar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you by the way add "enumDescriptions" for this setting here? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, and optimize star logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yihong0618 !
@jdneo @zry656565
Support star/unstar in codelen shortcuts/
image