-
Notifications
You must be signed in to change notification settings - Fork 674
Enhancement: Add leading zero for file navigation Issue #440 #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @aebopp,
I think we need a setting to turn on/off this feature.
@aebopp Do you still have the interest to update the PR?
Hi!
I’m not exactly sure how to add settings, so I guess not.
Thanks for checking in :)
On Thu, Jul 23, 2020 at 4:21 AM Sheng Chen ***@***.***> wrote:
@aebopp <https://github.com/aebopp> Do you still have the interest to
update the PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQ3PLTHW3XCJFEEL5FIFTTR47XG3ANCNFSM4OH73KGA>
.
--
Alexandria Bopp
University of Michigan | Class of 2020
B.S. English, Industrial and Operations Engineering
aebopp@umich.edu | 248-345-6720
Instead of hard code the prefix zeros, it will be better to let the user customize it. For example, in the setting leetcode.filePath, we can support something like ${id%05d} in the filename. This will provide enough flexibility to the users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified show.ts so files are named with leading zeros so they're in order in windows file navigation.
Works while there are less than 10,000 problems
#440
files