Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add re-run last test option #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanesau wants to merge 4 commits into LeetCode-OpenSource:master
base: master
Choose a base branch
Loading
from nathanesau:vscode-leetcode-570

Conversation

Copy link
Contributor

@nathanesau nathanesau commented Jun 12, 2020

re-run last option

Implement request from Issue #570

NikiforovAll and SurajMeena reacted with heart emoji
value: ":file",
},
{
label: "$(refresh) Re- run last...",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI: Use this icon please: $(debug-restart)

reference: https://microsoft.github.io/vscode-codicons/dist/codicon.html

Copy link
Member

jdneo commented Jun 27, 2020

Hey @nathanesau,

Thank you for your contribution, and sorry for the late reply...

I think it could be better if we use the icon debug-restart

Copy link
Member

jdneo commented Jul 23, 2020

@nathanesau, will you still have the interest to update the PR?

Copy link
Contributor Author

Sorry for the delay.

I have made the change (commit "use debug-start icon"):

re_run_last

value: ":file",
},
{
label: "$(debug-restart) Re-run last...",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion here: We should only show the re-run option when the lastTest is not empty. Also, this option should put at the top of the list, to make it more convenient for the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /