Jan 12, 2020 · Dec 3, 2019 · Dec 3, 2019 · Dec 3, 2019 · Dec 4, 2019 · Dec 4, 2019
diff --git a/README.md b/README.md
diff --git a/docs/README_zh-CN.md b/docs/README_zh-CN.md
diff --git a/package.json b/package.json
diff --git a/src/extension.ts b/src/extension.ts
diff --git a/src/leetCodeManager.ts b/src/leetCodeManager.ts
diff --git a/src/shared.ts b/src/shared.ts
Original file line number	Diff line number	Diff line change
Expand Up		@@ -56,6 +56,9 @@ Thanks for [@yihong0618](https://github.com/yihong0618) provided a workaround wh
		- LeetCode: Sign in (by cookie)
		- LeetCode: Sign out

	- You can also use the following command to sign in by third party:
Copy link Member @jdneo jdneo Dec 29, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Please only reserve the common login command as it was before.
	- LeetCode: Sign in by GitHub
	- LeetCode: Sign in by LinkedIn
		---

		### Switch Endpoint
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -56,6 +56,9 @@
		- LeetCode: Sign in (by cookie)
		- LeetCode: Sign out

	- 你也可以使用下列命令第三方登入:
	- LeetCode: Sign in by GitHub
	- LeetCode: Sign in by LinkedIn
		---

		### 切换 LeetCode 版本
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,16 +39,13 @@
		"onCommand:leetcode.submitSolution",
		"onCommand:leetcode.switchDefaultLanguage",
		"onCommand:leetcode.signinByCookie",
	"onCommand:leetcode.signinByGitHub",
	"onCommand:leetcode.signinByLinkedIn",
		"onView:leetCodeExplorer"
		],
		"main": "./out/src/extension",
		"contributes": {
		"commands": [
	{
	"command": "leetcode.signinByCookie",
	"title": "Sign In by Cookie",
	"category": "LeetCode"
	},
		{
		"command": "leetcode.deleteCache",
		"title": "Delete Cache",
Expand All		@@ -72,6 +69,21 @@
		"dark": "resources/dark/signin.svg"
		}
		},
	{
	"command": "leetcode.signinByCookie",
	"title": "Sign In by Cookie",
	"category": "LeetCode"
	},
	{
	"command": "leetcode.signinByGitHub",
	"title": "Sign In by GitHub",
	"category": "LeetCode"
	},
	{
	"command": "leetcode.signinByLinkedIn",
	"title": "Sign In by LinkedIn",
	"category": "LeetCode"
	},
		{
		"command": "leetcode.signout",
		"title": "Sign Out",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -52,6 +52,8 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
		vscode.commands.registerCommand("leetcode.toggleLeetCodeCn", () => plugin.switchEndpoint()),
		vscode.commands.registerCommand("leetcode.signin", () => leetCodeManager.signIn()),
		vscode.commands.registerCommand("leetcode.signinByCookie", () => leetCodeManager.signIn(true)),
	vscode.commands.registerCommand("leetcode.signinByGitHub", () => leetCodeManager.signIn(false, "GitHub")),
	vscode.commands.registerCommand("leetcode.signinByLinkedIn", () => leetCodeManager.signIn(false, "LinkedIn")),
		vscode.commands.registerCommand("leetcode.signout", () => leetCodeManager.signOut()),
		vscode.commands.registerCommand("leetcode.manageSessions", () => session.manageSessions()),
		vscode.commands.registerCommand("leetcode.previewProblem", (node: LeetCodeNode) => show.previewProblem(node)),
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,7 +6,7 @@ import { EventEmitter } from "events";
		import * as vscode from "vscode";
		import { leetCodeChannel } from "./leetCodeChannel";
		import { leetCodeExecutor } from "./leetCodeExecutor";
	import { UserStatus } from "./shared";
	import { UserStatus, LoginCommand } from "./shared";
		import { createEnvOption } from "./utils/cpUtils";
		import { DialogType, promptForOpenOutputChannel } from "./utils/uiUtils";
		import * as wsl from "./utils/wslUtils";
Expand Down Expand Up		@@ -34,8 +34,11 @@ class LeetCodeManager extends EventEmitter {
		}
		}

	public async signIn(isByCookie: boolean = false): Promise<void> {
	const loginArg: string = "-l";
	public async signIn(isByCookie: boolean = false, thirdParty: string = "Default"): Promise<void> {
	const loginArg: string \| undefined = LoginCommand.get(thirdParty);
	if (!loginArg) {
	throw new Error(`The third party "${thirdParty}" is not supported.`);
	}
		const cookieArg: string = "-c";
		const commandArg: string = isByCookie ? cookieArg : loginArg;
		const inMessage: string = isByCookie ? "sign in by cookie" : "sign in";
Copy link Member @jdneo jdneo Dec 29, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Is this variable `inMessage` used anywhere? Copy link Contributor Author @yihong0618 yihong0618 Dec 29, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Yes, it is for the difference of cookie login or other login message. e.g. promptForOpenOutputChannel(`Failed to ${inMessage}. Please open the output channel for details`
Expand Down Expand Up		@@ -82,7 +85,7 @@ class LeetCodeManager extends EventEmitter {
		childProc.stdin.write(`${pwd}\n`);
		childProc.stdin.end();
		childProc.on("close", () => {
	const match: RegExpMatchArray \| null = result.match(/(?:.) Successfully (login\|cookie login) as (.)/i);
	const match: RegExpMatchArray \| null = result.match(/(?:.) Successfully (login\|cookie login\|third party login) as (.)/i);
		if (match && match[2]) {
		resolve(match[2]);
		} else {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,6 +12,12 @@ export enum UserStatus {
		SignedOut = 2,
		}

	export const LoginCommand: Map<string, string> = new Map([
	["Default", "-l"],
	["GitHub", "-g"],
	["LinkedIn", "-i"],
	]);

		export const languages: string[] = [
		"bash",
		"c",
Expand Down