add leetcode.signinByCookie but simple change #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jdneo merged 6 commits into LeetCode-OpenSource:master from yihong0618:master

Dec 5, 2019

Merged

add leetcode.signinByCookie but simple change #487

jdneo merged 6 commits into LeetCode-OpenSource:master from yihong0618:master

Dec 5, 2019

Conversation

@yihong0618

Copy link

Contributor

@yihong0618 yihong0618 commented Dec 3, 2019 •

edited

Loading

This is very simple change maybe for short-term solution for #478
Sorry for the first time write ts.
Please help me review~
@jdneo
Thanks a lot.

yihong0618 added 3 commits

December 3, 2019 16:16

@yihong0618


 add leetcode.cookieIn but simple change

af76a8b

@yihong0618


 try to fix ci first time

@yihong0618


 try to fix ci second time

6ab8a3b

@jdneo

Copy link

Member

jdneo commented Dec 3, 2019 •

edited

Loading

Is it possible to leverage the cookie extension:

to bypass the reCAPTCHA?

Update: Forget it, it still introduces some requirements to use. Not ideal enough

@yihong0618

Copy link

Contributor Author

yihong0618 commented Dec 3, 2019

Yes, but I think this way is not so simple, I will try it tomorrow.

@jdneo

Copy link

Member

jdneo commented Dec 3, 2019

@yihong0618 I just took a look about the document. The cookie plugins need more requirements and they are different for different platforms. So I think it's not an ideal solution. Just forget it.

@yihong0618

Copy link

Contributor Author

yihong0618 commented Dec 3, 2019 •

edited

Loading

@jdneo me either. And this solution was for one-time session at that time.
I also think we read the cookie is worse than user paste it, because users will feel unsafe(not only the leetcode session but also others).

@yihong0618

Copy link

Contributor Author

yihong0618 commented Dec 4, 2019

@jdneo
cookie.chrome work.
But I think its not a good idea, it is no essential difference from the paste cookie method

jdneo

jdneo reviewed

Dec 4, 2019

View reviewed changes

Copy link

Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort @yihong0618.

I just have one concern about the command name. Maybe call it Sign in (by cookie) would be more easy to understand?

README.md Outdated

- You can also use the following command to sign in/out:

- You can also use the following command to sign in/cookie in/out:

- **LeetCode: Sign in**

- **LeetCode: Cookie in**

Copy link

Member

@jdneo jdneo Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming it to Sign in (by cookie)

Copy link

Contributor Author

@yihong0618 yihong0618 Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, should I also change name in leetcode.cookieIn command ?

Copy link

Contributor Author

@yihong0618 yihong0618 Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdneo
Have changed it~

@yihong0618


 rename cookie in to Sign in (by cookie)

8d24d57

@yihong0618 yihong0618 changed the title ~~(削除) add leetcode.cookieIn but simple change (削除ここまで)~~ (追記) add leetcode.signinByCookie but simple change (追記ここまで)

Dec 4, 2019

@yihong0618