-
Notifications
You must be signed in to change notification settings - Fork 689
replace icons in extension with vscode icons #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdneo
commented
Oct 10, 2019
Thanks, will take a look later.
Member
jdneo
commented
Oct 10, 2019
Hey @hologerry.
The globe icon works great from my side. Are you sure it's not working at your side?
BTW, I appended a commit to correct the color of the search icon in dark mode.
Author
For the stable VS Code version the globe icon works, however it does not work on the Insider VS Code version.
All icons are correct now on the latest stable VS Code version.
jdneo
jdneo
approved these changes
Oct 11, 2019
Member
jdneo
commented
Oct 11, 2019
Thanks @hologerry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
For issue #460