Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Activating Open Collective #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monkeywithacupcake wants to merge 2 commits into LeetCode-OpenSource:master
base: master
Choose a base branch
Loading
from opencollective:opencollective

Conversation

Copy link

@monkeywithacupcake monkeywithacupcake commented Sep 21, 2019

Hi, I'm making updates for Open Collective. Either you or another core contributor signed this repository up for Open Collective. This pull request adds financial contributors from your Open Collective https://opencollective.com/vscode-leetcode ❤️

What it does:

  • adds a badge to show the latest number of financial contributors
  • adds a banner displaying contributors to the project on GitHub
  • adds a banner displaying all individuals contributing financially on Open Collective
  • adds a section displaying all organizations contributing financially on Open Collective, with their logo and a link to their website

We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations. Feel free to remove it if you don't want it. [More info]

P.S: As with any pull request, feel free to comment or suggest changes.

Thank you for your great contribution to the Open Source community. You are awesome! 🙌
And welcome to the Open Collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other Open Source sustainers!

@@ -681,8 +681,13 @@
"highlight.js": "^9.15.6",
"lodash": "^4.17.13",
"markdown-it": "^8.4.2",
"opencollective-postinstall": "^2.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this dependency into the "devDependencies"?

@@ -7,7 +7,7 @@
</p>
<p align="center">
<a href="https://travis-ci.org/jdneo/vscode-leetcode">
<img src="https://img.shields.io/travis/jdneo/vscode-leetcode.svg?style=flat-square" alt="">
<a href="https://opencollective.com/vscode-leetcode" alt="Financial Contributors on Open Collective"><img src="https://opencollective.com/vscode-leetcode/all/badge.svg?label=financial+contributors" /></a> <img src="https://img.shields.io/travis/jdneo/vscode-leetcode.svg?style=flat-square" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the badge from:https://shields.io/ and adding the flat-square style? I saw it already support Open Collective


#### Organizations

Support this project with your organization. Your logo will show up here with a link to your website. [[Contribute](https://opencollective.com/vscode-leetcode/contribute)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool list here, may I ask how to update this list?

Copy link
Member

jdneo commented Oct 2, 2019

Hey @monkeywithacupcake,

Thank you for your help! Just leave some comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /