-
Notifications
You must be signed in to change notification settings - Fork 678
chore: replace the LeetCode.svg and LeetCode.png #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @poppinlp, could you fix the CI error?
ERROR Images in README.md must come from an HTTPS source: ./resources/LeetCode.png
This error is occured by the url of LeetCode.png
in README.md
and README_zh-CN.md
.
I've modified the url to local relative path instead of the file from master branch of github repository.
Actually, I think it's good to use relative path here since we should use the resources from current branch. But seems vsce dose not support it right now according to this issue.
I've changed it back to pass the travis CI.
Hey @poppinlp
Just one more question. Now the extension icon and the activity bar icon are both using the new picture. Are we mean to discard the activity bar icon that your friend designed just before?
I think I made a mistake. I should only replace the image in README. The previous activity icon is much more fits the sidebar. I'll bring it back now.
image
Uh oh!
There was an error while loading. Please reload this page.
LeetCode.svg
andLeetCode.png
Address #401