-
Notifications
You must be signed in to change notification settings - Fork 677
Add LeetCode extension as an activity bar item instead of a panel in Explorer item #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very cool! Thanks for the contribution @ntt2k.
Just one concern. could we use space instead of tab in the package.json?
Created an issue for this PR: #39
Yes, please. Thank you very much for accepting this.
You actually remind me one of the most famous developer's debate-->
https://www.youtube.com/watch?v=V7PLxL8jIl8
Haha, that's a classic debate.
Just want to make the indent same in this project.
Leave the choice to you when you are doing your own projects. 😄
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be a problem. Just curious about this field. Do you know where this field comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field could have come from vscode as I modified directly inside program's location on disk ".vscode\extensions" ... I think you can delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see...
Well I'm fine to change this myself, but I encourage that you can make the change directly in this PR, since this awesome feature is originally driven by you.
You can simply push the changes to your branch ntt2k:master then the PR here can automatically synced.
The changes we need to do are:
- repleace
tabtospace - remove the
__metadatafields inpackage.jon
Would you mind to do that? And please feel free to tell me if you have any question. 😄
Pretty cool! thanks.
Add LeetCode extension as an activity bar item instead of a panel in Explorer item.
For some people with a lot of pre-existence extensions already bloated the Explorer, this PR separate Leetcode extension as an individual activity bar item for easier navigation.
capture